Skip to content

new option and updated readme #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2015
Merged

new option and updated readme #27

merged 2 commits into from
Aug 24, 2015

Conversation

joshwnj
Copy link
Member

@joshwnj joshwnj commented Aug 8, 2015

Although we've discussed further improvements to the plugin architecture in #26 I'd like to add this new option in the meantime, since it's completely opt-in and doesn't affect existing behaviour.

@joshgillies pls take a look and merge if you're happy with it.

@joshgillies
Copy link
Member

Sorry for the delay in getting onto this!

So I worry about this. In that in terms of an API it feels sloppy. Would it be better to change how the -u works, to basically not nuke the default PostCSS plugins for CSS Modules?

That being said, if the goal is to eventually re-architect the way plugins are handled anyway and assuming this PR solves problems people are having currently I'd be OK to +1 this.

Would it be much effort to tack on a CLI option to set this also? --after [pluginA, pluginB] maybe?

@joshwnj
Copy link
Member Author

joshwnj commented Aug 19, 2015

Yeah, I think longer-term it would be better to change the behaviour of -u so that by default the css modules plugins are preserved. Would you be happy with this as a non-breaking-change solution for now, and then aim to change -u when we go to 1.0?

I'll look at adding the --after CLI option.

@joshgillies
Copy link
Member

Assuming we can get the CLI to feature parody with the Core API I'd be keen to release this.

Thanks for making this happen! 👍

@joshwnj
Copy link
Member Author

joshwnj commented Aug 24, 2015

@joshgillies I've added --after for CLI, please take a look and merge if you're happy with it.

@joshgillies
Copy link
Member

Happy days! 😄

Merging!

joshgillies added a commit that referenced this pull request Aug 24, 2015
new option `--after` and updated readme
@joshgillies joshgillies merged commit ded3433 into master Aug 24, 2015
@joshwnj joshwnj deleted the postcss-after branch August 24, 2015 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants