there is no need to wrap bundle #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thanks @wenbing ! This is definitely a more "proper" way to use browserify :) Then only question in my mind is that previously, the I'm not sure if that's going to cause any issues but at this stage I'm happy to go ahead and accept this PR, and fix any issues that arise. @joshgillies can you think of any reason this shouldn't be merged? |
|
This has bugged me for some time. Looks solid! 👍 Merging! |
joshgillies
added a commit
that referenced
this pull request
Aug 24, 2015
Remove wrapped browerify bundle function
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.