update to allow passing a generateScopedName func directly #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 Thanks for the work on this! |
|
Looks really good, thanks @joshwnj !! Merging 👍 |
joshgillies
added a commit
that referenced
this pull request
Sep 21, 2015
update to allow passing a generateScopedName func directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to add a new
generateScopedNameoption.By default it uses
generateLongName, which is similar to the current behaviour. But ifNODE_ENV=productionit will use a shorter name (file hash + line number).This also means a cleaner API, setting
generateScopedNamedirectly oncss-modulesifyrather than needing to reach in and set it as an option of the postcss plugin.