fix a race-condition with tokensByFile #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we’re setting `tokensByFile` before and after an async action, and many of these actions can happen at the same time, there’s a race condition where the incorrect `tokensByFile` can be set. This accomplishes the same desire for caching by just keeping the loader for every file since the loader already caches `tokensByFile`, and prevents the race condition.
|
@joshwnj would it be possible for you to take a look at this? |
|
Sorry about the wait - just took a look and tried out with a few things. Looks good, thanks! 👍 |
joshwnj
added a commit
that referenced
this pull request
Oct 2, 2015
fix a race-condition with tokensByFile
|
Published 0.9.0 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we’re setting
tokensByFilebefore and after an async action,and many of these actions can happen at the same time, there’s a race
condition where the incorrect
tokensByFilecan be set.This accomplishes the same desire for caching by just keeping the loader
for every file since the loader already caches
tokensByFile, andprevents the race condition.