Skip to content

Fix separation of loaders #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2016
Merged

Fix separation of loaders #77

merged 2 commits into from
Feb 3, 2016

Conversation

tjallingt
Copy link
Contributor

Fixes #76
(also included some code style fixes as suggested by the linter)

inoc603 added a commit to Orientsoft/react-orientboard that referenced this pull request Jan 21, 2016
@huan086
Copy link

huan086 commented Jan 25, 2016

It works. Thanks!
However, for this to work, output cannot be optional, so the docs needs to updated too

output: path to write the generated css. If not provided, you'll need to listen to the 'css stream' event on the bundle to get the output.

@joeybaker
Copy link
Contributor

FWIW, output is optional so that you can get the output as a stream instead of a file. It would be great if the solution worked for both of these use-cases.

@tjallingt
Copy link
Contributor Author

As far as I can tell it doesn't change the functionality when not given a cssOutFilename as it will just store the loader the same as before. This fix only changes the functionality of the code when presented with multiple different cssOutFilenames....

@joeybaker
Copy link
Contributor

cool beans.

@joshwnj
Copy link
Member

joshwnj commented Feb 3, 2016

Thanks for these updates @tjallingt , and for being patient while I got some time to review :)

joshwnj added a commit that referenced this pull request Feb 3, 2016
Fix separation of loaders
@joshwnj joshwnj merged commit f306d5f into css-modules:master Feb 3, 2016
@joshwnj
Copy link
Member

joshwnj commented Feb 3, 2016

published v0.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple browserify instances get mixed up
4 participants