Skip to content

Conversation

@tjallingt
Copy link
Contributor

fixes #75

@tjallingt
Copy link
Contributor Author

Perhaps some tests for this change would be nice but I have no idea how to fit that into the current testing framework. 😟

@tjallingt
Copy link
Contributor Author

actually im not sure why that options.d is there so i should have probably put it before the basedir...

@joshwnj
Copy link
Member

joshwnj commented Feb 9, 2016

@tjallingt options.d is the shorthand of the rootDir argument. Let's put it before basedir, and then we'll be good to merge :) Thanks!

@tjallingt
Copy link
Contributor Author

done 😄

joshwnj added a commit that referenced this pull request Feb 22, 2016
Use browserify basedir as a fallback for rootDir
@joshwnj joshwnj merged commit 71b66c1 into css-modules:master Feb 22, 2016
@joshwnj
Copy link
Member

joshwnj commented Feb 22, 2016

Thanks @tjallingt , published v0.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consider Browserify basedir for rootDir

2 participants