Skip to content

Emit on pack stage of pipeline #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2016
Merged

Conversation

danielmoore
Copy link
Contributor

This PR moves the CSS and JSON emitting to the pack stage of the Browserify pipeline, similar to how factor-bundle works. This change enables other plugins to listen to the css stream event and react within the Browserify pipeline as well.

This PR also uses module.parent.require to pull in plugins that were given by string. This has no effect in normal situations, but allows this library to be linked in via npm link.

@joshwnj
Copy link
Member

joshwnj commented May 20, 2016

Thanks @danielmoore , looks interesting. Sorry for the delay, I'm trying to find some time to give a proper review before merging :)

Btw have you tried using css-modulesify with factor-bundle?

@danielmoore
Copy link
Contributor Author

I'm actually using this change in conjunction with zoubin/factor-vinylify#1

@joshwnj
Copy link
Member

joshwnj commented Jun 18, 2016

Thanks @danielmoore ! I'll merge this now, and I'm also in the middle of a cleanup which will affect a few things here. So I'll ask you to check it once more after the cleanup.

@joshwnj joshwnj merged commit 9ae3f4a into css-modules:master Jun 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants