unescapeString doesn't properly unescape unicode characters #12
Comments
pieter
pushed a commit
to pieter/css-selector-tokenizer
that referenced
this issue
Apr 13, 2016
This fixes the parsing of unicode strings that are 1 or 6 hex characters long. Extends the tests to support a third element in examples, which would be the re-stringified example, since a unicode character might be stringified in a different way than the original code, and still be valid. fixes webpack-contrib/css-loader#133 fixes css-modules#12
pieter
added a commit
to pieter/css-selector-tokenizer
that referenced
this issue
Apr 13, 2016
This fixes the parsing of unicode strings that are 1 or 6 hex characters long. Extends the tests to support a third element in examples, which would be the re-stringified example, since a unicode character might be stringified in a different way than the original code, and still be valid. fixes webpack-contrib/css-loader#133 fixes css-modules#12
|
Can we please have this fix put in and bump the version in css-loader? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following are valid unicode escaped strings:
'\a''\00000A'Both of these aren't matched by
unescapeString(), which wants to have at least 2 characters and a maximum of 5. In fact stringifyValues() can stringily to'\A', which then can't be parsed again by parseValues().The text was updated successfully, but these errors were encountered: