-
Notifications
You must be signed in to change notification settings - Fork 21
Add build to avoid using regexpu-core in runtime #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 187 188 +1
=========================================
+ Hits 187 188 +1
Continue to review full report at Codecov.
|
|
heya @evilebottnawi, any chance you could check this optimization out? It makes |
|
@geelen we'd really appreciate it if someone can review and merge or comment on this PR. |
|
@sokra @evilebottnawi I would appreciate if someone could take a look on this PR. We are currently using a work around to avoid the huge size increase. |
|
@barak007 Where we use this module? Wi migrate on postcss and postcss-selector-parser |
|
@evilebottnawi we are using it in several places in https://github.com/wix/stylable This PR solves a size regression that affects anyone who bundles |
alexander-akait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can we merge and do release? It is just a patch, nothing changes, yes?
|
Yes, it can be a patch release. 👍 |
|
Done, |
This PR moves
regexpu-coreto be a dev dependency to save 380k when creating a web bundle by transpiling the usages in build time.Also might have a minor speed up at initialization time.
Fixes #22