Skip to content

Support new :is and :where parsing #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

barak007
Copy link
Contributor

Add support for parsing :is and :where as nested-pseudo-classes

@barak007 barak007 changed the title New nested pseudo Support new :is and :where parsing May 26, 2021
@barak007
Copy link
Contributor Author

barak007 commented Jun 1, 2021

@alexander-akait do you accept PR's here?

@alexander-akait
Copy link
Member

Should we add :matches()/:any()?

@barak007
Copy link
Contributor Author

barak007 commented Jun 1, 2021

:matches - is renamed to :is and not going to be implemented.
Also :matches is already parsed as nested-pseudo-class... maybe we should remove it someday.
:any - I couldn't find reference to it in the spec and also it currently only works with prefixes so I'm not sure.

@alexander-akait
Copy link
Member

https://developer.mozilla.org/en-US/docs/Web/CSS/:is, just worried that someone might use the old names, but they have been renamed

@barak007
Copy link
Contributor Author

barak007 commented Jun 1, 2021

ok.
I added :any and :-vendor-any.
:matches already supported

@alexander-akait alexander-akait merged commit 4052d12 into css-modules:master Jun 1, 2021
@alexander-akait
Copy link
Member

Thanks

@alexander-akait
Copy link
Member

@barak007 Released https://github.com/css-modules/css-selector-tokenizer/releases/tag/v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants