Icss utils #105
Merged
Icss utils #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mightyaleksey
requested changes
May 24, 2017
src/icss.js
Outdated
| .append(declarations) | ||
| } | ||
|
|
||
| export const createICSSRules = (imports, exports) => [ |
There was a problem hiding this comment.
let's stick to one syntax of modules? commonjs or imports?
src/index.js
Outdated
| @@ -105,12 +79,10 @@ module.exports = postcss.plugin('postcss-modules-values', () => ( | |||
| }) | |||
|
|
|||
| /* If we have no definitions, don't continue */ | |||
| if (Object.keys(definitions).length === 0) return | |||
| if (Object.keys(exports).length === 0) return | |||
There was a problem hiding this comment.
I also would like to suggest to use icssExports as the variable name instead of plain exports, cause sometimes it can not be easy to distinguish icss exports from module.exports.
and maybe fix the comment or remove it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @sullenor
In the next PR I'd like to isolate alias indexing in one call.