Skip to content

Add multi-line imports #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Add multi-line imports #42

merged 1 commit into from
Aug 9, 2016

Conversation

jerrysu
Copy link

@jerrysu jerrysu commented Mar 18, 2016

This adds support for multi-line imports wrapped in parentheses: #41

I added a test for:

@value (
  blue,
  red
) from './colors.css';

The following are also allowed:

@value (blue, red) from './colors.css';
@value (blue) from './colors.css';

Let me know if you'd prefer to change anything or would like to add or re-organize the tests somehow. I can also add to the README.md as well.

@jerrysu jerrysu changed the title Add multi-line @value imports Add multi-line imports Mar 18, 2016
@andywer
Copy link

andywer commented Apr 14, 2016

Any reason why this PR has not yet been approved? This is indeed very helpful if you import a lot of values from another file :)

@witwit
Copy link

witwit commented Jun 10, 2016

would love to see this approved ASAP. Multi-line imports is a must for serious theming :-/

@andywer
Copy link

andywer commented Jun 10, 2016

@ai Is there anything we could do to get the repo owner's attention? It's the css modules core plugins. They should definitely be maintained by someone... :-/

@ai
Copy link

ai commented Jun 10, 2016

@geelen ^

@witwit
Copy link

witwit commented Jun 10, 2016

@andywer perhaps make an own fork - the remedy of last resort?

@andywer
Copy link

andywer commented Jun 10, 2016

@witwit As a last resort, sure. But I would rather not if there is a way around... Maybe set some random deadline just for ourselves? Like two weeks and if there is still no solution at the time then we fork.

@witwit
Copy link

witwit commented Jun 13, 2016

@andywer, sounds like a plan :-)

@axelson
Copy link

axelson commented Aug 9, 2016

Any progress on this?

@geelen
Copy link
Member

geelen commented Aug 9, 2016

Sorry! This has been not-really-maintained for a while now. But I'm back.

@geelen geelen merged commit b7823a8 into css-modules:master Aug 9, 2016
@witwit
Copy link

witwit commented Aug 9, 2016

Great! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants