-
Notifications
You must be signed in to change notification settings - Fork 6
Update to PostCSS 5.x #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+1 |
See webpack-contrib/css-loader#135 |
Yeah, I'll merge in the changes from master. BTW, never rebase on a branch you've pushed to others. The commit SHAs change, so things like Github line comments and other stuff gets screwed up. Been bit by that before! 😉 |
@timdorr GitHub used to have issues w/ comments on outdated diffs, but they've since fixed that. We rebase all the time and outdated diffs end up looking like this: There might still be issues when commenting directly on a commit, but we tend to avoid doing that anyway, for the very reason you pointed out; though, they might have fixed that recently as well. On this PR, however, there have been no line comments, it's very small, and you would benefit from doing a rebase for a clean merge. |
@timdorr I just confirmed that commit comments are, in fact, wiped out. This is why you should try your best to comment on the "Files changed" diff/tab until GitHub finds a magical solution for that too. Again though, this PR has no commit comments, so it's irrelevant here. |
Thanks |
@sokra are you going to publish a new major version on npm soon? |
New version will land this week in the big |
No description provided.