Skip to content

Update to PostCSS 5.x #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2015
Merged

Update to PostCSS 5.x #6

merged 4 commits into from
Sep 15, 2015

Conversation

timdorr
Copy link
Contributor

@timdorr timdorr commented Sep 9, 2015

No description provided.

@minhtranite
Copy link

+1

@jednano
Copy link

jednano commented Sep 14, 2015

See webpack-contrib/css-loader#135
@timdorr it looks like this one needs a rebase?

@timdorr
Copy link
Contributor Author

timdorr commented Sep 14, 2015

Yeah, I'll merge in the changes from master.

BTW, never rebase on a branch you've pushed to others. The commit SHAs change, so things like Github line comments and other stuff gets screwed up. Been bit by that before! 😉

@jednano
Copy link

jednano commented Sep 14, 2015

@timdorr GitHub used to have issues w/ comments on outdated diffs, but they've since fixed that. We rebase all the time and outdated diffs end up looking like this:

image

There might still be issues when commenting directly on a commit, but we tend to avoid doing that anyway, for the very reason you pointed out; though, they might have fixed that recently as well.

On this PR, however, there have been no line comments, it's very small, and you would benefit from doing a rebase for a clean merge.

@jednano
Copy link

jednano commented Sep 14, 2015

@timdorr I just confirmed that commit comments are, in fact, wiped out. This is why you should try your best to comment on the "Files changed" diff/tab until GitHub finds a magical solution for that too.

Again though, this PR has no commit comments, so it's irrelevant here.

sokra added a commit that referenced this pull request Sep 15, 2015
@sokra sokra merged commit 45c72b3 into css-modules:master Sep 15, 2015
@sokra
Copy link
Member

sokra commented Sep 15, 2015

Thanks

@jednano
Copy link

jednano commented Sep 18, 2015

@sokra are you going to publish a new major version on npm soon?

@geelen
Copy link
Member

geelen commented Sep 19, 2015

New version will land this week in the big 1.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants