Skip to content

Adds safety check before accessing "rule parent" #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2019
Merged

Adds safety check before accessing "rule parent" #15

merged 1 commit into from
May 15, 2019

Conversation

kettanaito
Copy link
Contributor

@kettanaito kettanaito commented May 15, 2019

Adds an explicit safety check when accessing properties of rule.parent instance.

This fixes the issue I'm currently experiencing with the latest versions of all css-related dependencies installed. See #7 for more details from my side. Thanks.

GitHub

@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #15 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   99.31%   99.31%   +<.01%     
==========================================
  Files           2        2              
  Lines         291      292       +1     
  Branches       91       92       +1     
==========================================
+ Hits          289      290       +1     
  Misses          2        2
Impacted Files Coverage Δ
index.js 99.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7291e...2024950. Read the comment docs.

@alexander-akait alexander-akait merged commit 9b9a346 into css-modules:master May 15, 2019
@kettanaito
Copy link
Contributor Author

Thank you, @evilebottnawi!

@kettanaito kettanaito deleted the 7-rule-parent-check branch May 15, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help with css-loader error
3 participants