Skip to content

fix: unicode characters #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 5, 2018

css-selector-tokenizer parse and stringify unicode value (not only) very bad and with bugs - switch to stable value parser

@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #4 into master will decrease coverage by 0.43%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage     100%   99.56%   -0.44%     
==========================================
  Files           2        2              
  Lines         238      232       -6     
  Branches       60       65       +5     
==========================================
- Hits          238      231       -7     
- Misses          0        1       +1
Impacted Files Coverage Δ
test.js 100% <ø> (ø) ⬆️
index.js 99.5% <97.22%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0128ed...81b4035. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #4 into master will decrease coverage by 0.86%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage     100%   99.13%   -0.87%     
==========================================
  Files           2        2              
  Lines         238      232       -6     
  Branches       60       65       +5     
==========================================
- Hits          238      230       -8     
- Misses          0        2       +2
Impacted Files Coverage Δ
test.js 100% <ø> (ø) ⬆️
index.js 99.01% <94.44%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0128ed...be59c25. Read the comment docs.

@alexander-akait alexander-akait merged commit 83c87d2 into master Dec 5, 2018
@alexander-akait alexander-akait deleted the fix-unicode-characters branch December 5, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants