Skip to content

fix: Allow for usage of special characters in keyframes name #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ function localizeDeclaration(declaration, context) {
const isAnimation = /animation$/i.test(declaration.prop);

if (isAnimation) {
const validIdent = /^-?[_a-z][_a-z0-9-]*$/i;
const validIdent = /^-?(?:\\[~!@$%^&*()+=,./';:"?><[]\\{}|`#]|[_a-z])(?:\\[~!@$%^&*()+=,./';:"?><[]\\{}|`#]|[_a-z0-9-])*$/i;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show where you get this regexp 😄 Ident token from spec https://www.w3.org/TR/css-syntax-3/#typedef-ident-token

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That spec seems to only explain escaping Unicode points (ie \00002b)

They have a diagram labeled escape which seems to indicate the character following the escape can be any character except newline - the spec explicitly says that the diagrams are not 100% accurate though, so I'm not sure how much stock I should put in that.

I got this list from the following post:
https://mathiasbynens.be/notes/css-escapes

Cross referencing some SO posts seemed to confirm this list.

Would it be better to have a more relaxed regex around escapes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with it, just want to verify

Copy link
Author

@william-will-angi william-will-angi Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything else you would like me to address before getting these changes in? (not sure what dev process is for this repo)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait I hope I'm not bothering. Is this MR ready to go?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would limiting the scope of these changes to the special character @ speed this MR along? That is the only character currently affecting our projects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay, yes, I think let's do it to avoid big perf regression


/*
The spec defines some keywords that you can use to describe properties such as the timing
Expand Down
12 changes: 12 additions & 0 deletions test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,18 @@ const tests = [
expected:
"@keyframes :local(foo) { from { color: red; } to { color: blue; } }",
},
{
name: "localize keyframes starting with special characters",
input: "@keyframes \\@foo { from { color: red; } to { color: blue; } }",
expected:
"@keyframes :local(\\@foo) { from { color: red; } to { color: blue; } }",
},
{
name: "localize keyframes containing special characters",
input: "@keyframes f\\@oo { from { color: red; } to { color: blue; } }",
expected:
"@keyframes :local(f\\@oo) { from { color: red; } to { color: blue; } }",
},
{
name: "localize keyframes in global default mode",
input: "@keyframes foo {}",
Expand Down