chore: migrate off of css-selector-tokenizer #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 99.58% 99.62% +0.04%
==========================================
Files 2 2
Lines 243 270 +27
Branches 71 82 +11
==========================================
+ Hits 242 269 +27
Misses 1 1
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Feb 19, 2019
alexander-akait
requested changes
Feb 19, 2019
| "semi": true, | ||
| "singleQuote": true, | ||
| "trailingComma": "es5" | ||
| }, | ||
| "dependencies": { | ||
| "css-selector-tokenizer": "^0.7.0", |
There was a problem hiding this comment.
Remove this from deps and update lock file 👍
|
/cc @jquense ready for merge? Please fix small note |
|
I will continue development, merge this as is |
|
thanks! sorry didn't have a moment to finish it up in the last two days! |
|
/cc @jquense just clarify: all finished in this PR? |
|
yup, just the note you said |
|
@jquense i will start testing new PR with css-loader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty hard :/ And i don't think there is way to be super confident that there isn't some subtle change in behavior due to api differences, unclear behavior, limited tests.
I think actually the right thing to do here is REMOVE support for the non-nested selector. the open ended selector is weird and inconsistent, even in the logic of this plugin there is unclear transformations. and I even added a test to ensure i wasn't changing something but the old behavior that is definitely wrong.