This repository was archived by the owner on Feb 9, 2018. It is now read-only.
Test cleanup #153
Merged
Test cleanup #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var valueErr = /^CSSUnparsedValue should be an array of string or CSSVariableReferenceValue$/; | ||
| assert.throws(function() { new CSSUnparsedValue(1); }, TypeError, valueErr); | ||
| assert.throws(function() { new CSSUnparsedValue("123"); }, TypeError, valueErr); | ||
| assert.throws(function() { new CSSUnparsedValue({ h:10, w:5, d:4, t:"5" });}, TypeError, valueErr); |
There was a problem hiding this comment.
Nit: Should not have space after { or before } in objects, should have space between : and following thing, e.g. {h: 10, w: 5}
|
LGTM with small nit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up tests code. Uses
assert.throws, notthrow; changes tocloseTofromapproximate.Also adds regex error matching, including adding a few message matches where there were none.