Fix CSScomb when Sass tmLanguage installed#52
Merged
tonyganch merged 1 commit intocsscomb:masterfrom Feb 3, 2015
karlhorky:patch-1
Merged
Fix CSScomb when Sass tmLanguage installed#52tonyganch merged 1 commit intocsscomb:masterfrom karlhorky:patch-1
tonyganch merged 1 commit intocsscomb:masterfrom
karlhorky:patch-1
Conversation
CSScomb.py
Outdated
Member
There was a problem hiding this comment.
Oh, wow, thank you!
But you know what, there should actually be def is_sass() returning sass as a syntax name, not scss.
The Sass tmLanguage package can be used to highlight SCSS and Sass files. If used on an SCSS file, CSSComb does not run (since it does not match the scope name as starting with `source.scss`). This commit enables CSSComb for both Sass and SCSS files when being highlighted with the Sass tmLanguage package. Fixes #18
Contributor
Author
|
@tonyganch No problem, glad to help :) Please review again. I've added |
tonyganch
added a commit
that referenced
this pull request
Feb 3, 2015
Fix CSScomb when Sass tmLanguage installed
Member
|
Thank you! 🐘 |
Contributor
Author
|
Thanks for the merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSScomb was not running when Sass tmLanguage was used for syntax highlighting.
Fixes #18