fix 'let students take this quiz now' so that it correctly unlocks the quiz

when unlocking a quiz (with no time limit or for a specified period), the
quiz will now unlock correctly, and the students will be able to take it.

fixes CNVS-11727

test plan:
  - Create a quiz. Set a due date, but no "from" or "until" date.
  - Save and publish the quiz.
  - Lock the quiz; note that the date/time at which you lock it now appears in the "until" field.
  - Unlock the quiz with "No time limit". Note that the current date/time appears in the
      "Available from" cell, and the "Until" date has been cleared out.
  - Verify that you are able to take the quiz as a student, and note that there is no
      specified end date for the quiz.
  - Lock the quiz again, then unlock the quiz with a time limit (choose any date). Note that
      the current date appears in the "Available from" cell, and the specified end date
      appears in the "Until" cell.
  - Verify that you are able to take the quiz as a student, and note that there is a specified
      end date for the quiz.

Change-Id: I94ed3e26b7c91e84728c27e58c0e130444ef95a2
Reviewed-on: https://gerrit.instructure.com/42016
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>

Author: spencerolson

app/views/quizzes/quizzes/show.html.erb

@@ -136,7 +136,7 @@
               </li>
               <a href="<%= context_url(@context, :context_rubrics_url) %>" class="icon-rubric" id="add_rubric_url" style="display:none">&nbsp;</a>
             <% end %>
-  
+
             <% if can_do(@quiz, @current_user, :update) && !needs_unpublished_warning? %>
               <li role="presentation">
                 <a href="<%= course_quiz_take_path(@context, @quiz, preview: 1) %>" class="preview_link" data-method="post" tabindex="-1" role="menuitem">
@@ -145,10 +145,10 @@
                 </a>
               </li>
             <% end %>
-  
+
             <% if can_do(@quiz, @current_user, :update) %>
               <% if @quiz.locked? %>
-                <%= form_for @quiz, :url => context_url(@context, :context_quiz_url, @quiz.id), :html => { :id => 'quiz_unlock_form' } do |f| %>
+                <%= form_for @quiz, as: :quiz, method: :put, :url => context_url(@context, :context_quiz_url, @quiz.id), :html => { :id => 'quiz_unlock_form' } do |f| %>
                   <%= hidden_field_tag 'quiz[locked]', false %>
                   <div id="unlock_for_how_long_dialog" title="<%= t('titles.unlock_for_how_long', "How long would you like to unlock the quiz for?") %>" style="display:none;">
                     <label style="float: left;" for="no_time_limit">
@@ -169,7 +169,7 @@
                   </a>
                 </li>
               <% else %>
-                <%= form_for @quiz, :url => context_url(@context, :context_quiz_url, @quiz.id), :html => { :id => 'quiz_lock_form' } do |f| %>
+                <%= form_for @quiz, as: :quiz, method: :put, :url => context_url(@context, :context_quiz_url, @quiz.id), :html => { :id => 'quiz_lock_form' } do |f| %>
                   <%= hidden_field_tag 'quiz[locked]', true %>
                 <% end %>
                 <% qos_lock_quiz_title = @quiz.survey? ? t('buttons.lock_survey', "Lock this Survey Now") : t('buttons.lock_quiz', "Lock this Quiz Now") %>
@@ -180,13 +180,13 @@
                 </li>
               <% end %>
             <% end %>
-  
+
             <% if (can_do(@quiz, @current_user, :grade) || can_do(@quiz, @current_user, :review_grades)) && @quiz.available? %>
               <li role="presentation">
                 <a href="#" class="quiz_details_link" tabindex="-1" role="menuitem">
                   <% if @any_submissions_pending_review %>
                     <i class="icon-warning" aria-label="<%= t("labels.warning_icon", "Warning") %>"></i>
-  
+
                   <% end %>
                   <i class="icon-group"></i>
                   <span id="quiz_details_text">
@@ -196,7 +196,7 @@
                 </a>
               </li>
             <% end %>
-  
+
             <% if can_do(@quiz, @current_user, :grade) && can_do(@context, @current_user, :send_messages) && @quiz.available? && !@quiz.anonymous_submissions? && @quiz.graded? %>
               <% message_students_who_title = t('links.message_students_who', "Message Students Who...") %>
               <li role="presentation">
@@ -205,7 +205,7 @@
                 </a>
               </li>
             <% end %>
-  
+
             <li role="presentation">
               <a href="<%= context_url(@context, :context_quiz_url, @quiz) %>" class="delete_quiz_link" tabindex="-1" role="menuitem">
                 <i class="icon-trash"><span class="screenreader-only"><%= admin_delete_title %></span></i> <%= admin_delete_title %>
@@ -355,7 +355,7 @@
 
                 <% if can_do(@quiz, @current_user, :update) %>
                   <% if @quiz.locked? %>
-                    <%= form_for @quiz, :url => context_url(@context, :context_quiz_url, @quiz.id), :html => { :id => 'quiz_unlock_form' } do |f| %>
+                    <%= form_for @quiz, as: :quiz, method: :put, :url => context_url(@context, :context_quiz_url, @quiz.id), :html => { :id => 'quiz_unlock_form' } do |f| %>
                       <%= hidden_field_tag 'quiz[locked]', false %>
                       <div id="unlock_for_how_long_dialog" title="<%= t('titles.unlock_for_how_long', "How long would you like to unlock the quiz for?") %>" style="display:none;">
                         <label style="float: left;" for="no_time_limit">
@@ -376,7 +376,7 @@
                       </a>
                     </li>
                   <% else %>
-                    <%= form_for @quiz, :url => context_url(@context, :context_quiz_url, @quiz.id), :html => { :id => 'quiz_lock_form' } do |f| %>
+                    <%= form_for @quiz, as: :quiz, method: :put, :url => context_url(@context, :context_quiz_url, @quiz.id), :html => { :id => 'quiz_lock_form' } do |f| %>
                       <%= hidden_field_tag 'quiz[locked]', true %>
                     <% end %>
                     <% qos_lock_quiz_title = @quiz.survey? ? t('buttons.lock_survey', "Lock this Survey Now") : t('buttons.lock_quiz', "Lock this Quiz Now") %>