fix version number preload for no versions

refs CNVS-32804

otherwise it will still query individually

Change-Id: I46b078b6f3bcf509e8844c3e698b991178ee838e
Reviewed-on: https://gerrit.instructure.com/94370
Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>

Author: ccutrer

app/models/assessment_question.rb

@@ -237,7 +237,7 @@ def self.find_or_create_quiz_questions(assessment_questions, quiz_id, quiz_group
         group_by(&:assessment_question_id)
 
     assessment_questions.map do |aq|
-      aq.force_version_number(current_versions[aq.id])
+      aq.force_version_number(current_versions[aq.id] || 0)
       qq = existing_quiz_questions[aq.id].try(:first)
       if !qq
         begin

spec/models/assessment_question_spec.rb

@@ -217,16 +217,19 @@ def attachment_in_course(course)
     end
 
     it 'should find and update an out of date quiz_question' do
-      qq = AssessmentQuestion.find_or_create_quiz_questions([assessment_question], quiz.id, nil).first
+      aq = assessment_question
+      qq = AssessmentQuestion.find_or_create_quiz_questions([aq], quiz.id, nil).first
 
-      assessment_question.name = 'changed'
-      assessment_question.with_versioning(&:save!)
+      aq = AssessmentQuestion.find(aq)
+      aq.name = 'changed'
+      aq.with_versioning(&:save!)
 
-      expect(qq.assessment_question_version).to_not eql(assessment_question.version_number)
+      expect(qq.assessment_question_version).to_not eql(aq.version_number)
 
-      qq2 = AssessmentQuestion.find_or_create_quiz_questions([assessment_question], quiz.id, nil).first
+      qq2 = AssessmentQuestion.find_or_create_quiz_questions([aq], quiz.id, nil).first
+      aq = AssessmentQuestion.find(aq)
       expect(qq.assessment_question_version).to_not eql(qq2.assessment_question_version)
-      expect(qq2.assessment_question_version).to eql(assessment_question.version_number)
+      expect(qq2.assessment_question_version).to eql(aq.version_number)
     end
 
     it "grabs the first match by ID order" do