Skip to content

feat: postcss 8 and new modern postcss API #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Conversation

anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Sep 20, 2020

Adding support for new postcss 8 and its new API

Status

  • dep updates
  • test helpers
  • site playground
  • cssnano core
  • postcss-colormin
  • postcss-convert-values
  • postcss-discard-comments
  • postcss-discard-empty
  • postcss-discard-duplicates
  • postcss-discard-overridden (the test runner needs to be fixed)
  • postcss-discard-unused
  • postcss-merge-idents
  • postcss-merge-longhand
  • postcss-merge-rules
    • plugin refactor
    • tests case for should not crash when node.raws.value is null not working properly as postcss runner is not able to run the plugin - maybe the postcss is < 8 there, not sure. error 'true' is not a postcss plugin when using the postcss-simple-vars plugin
  • postcss-minify-font-values
  • postcss-minify-gradients
  • postcss-minify-params
  • postcss-minify-selectors
  • postcss-normalize-charset
  • postcss-normalize-display-values
  • postcss-normalize-positions
  • postcss-normalize-repeat-style
  • postcss-normalize-string
  • postcss-normalize-timing-functions
  • postcss-normalize-unicode
  • postcss-normalize-url
  • postcss-normalize-whitespace
  • postcss-ordered-values
  • postcss-reduced-idents
  • postcss-reduced-initial
  • postcss-reduced-transform
  • postcss-svgo
  • postcss-unique-selectors
  • postcss-zindex
  • stylehacks
  • postcss-calc (external)
    • it is supported in upstream
    • need to update dependency in our end
  • css-declaration-sorter (external)
  • autoprefixer (external)
    • it is supported in upstream
    • need to update dependency in our end

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate PRs, one plugin = one PR, PostCSS 8 should have compatibility with existing plugins, so we will have only warnings, if you faced with a error, need report to postcss repo

@anikethsaha
Copy link
Member Author

I guess there would be some issues as we have our own runner. here

here is the diff

So I guess it is better to do this in a single one itself. We do have nightly as well and implementing some support for postcss 8 and rest in postcss 7 might break.

ifiokjr added a commit to remirror/remirror that referenced this pull request Sep 24, 2020
Too many other packges depend on the previous API.

Upgrade again once cssnano migrates.

WATCH: cssnano/cssnano#954
@ludofischer
Copy link
Collaborator

Hi, would you find it useful if I converted some of the remaining plugins myself? I could open a pull request against your postcss-8 branch.

@anikethsaha
Copy link
Member Author

Hi, would you find it useful if I converted some of the remaining plugins myself? I could open a pull request against your postcss-8 branch.

Sounds good. @evilebottnawi do we have to wait for the postcss fixes you were working on to continue in this?

@alexander-akait
Copy link
Member

@anikethsaha I think all problems fixes in 8.1, so we can continue to update

@ludofischer
Copy link
Collaborator

Shall I start from postcss-normalize-charset and go down the checkbox list?

@anikethsaha
Copy link
Member Author

Shall I start from postcss-normalize-charset and go down the checkbox list?

Sure,
I would recommend not to update the integration test's fixtures. We will do that once everything is migrated. You can update rhe plugin's tests.

@ludofischer
Copy link
Collaborator

All right. BTW, when I run yarn test:only on the postcss-8 branch, Jest hangs. It prints the test results summary so it does manages to run all the tests anyway.

@alexander-akait
Copy link
Member

Done in master

@alexander-akait alexander-akait deleted the postcss-8 branch January 11, 2021 12:46
@frederikhors
Copy link

Please can you release it? The world is waiting for you.

@alexander-akait
Copy link
Member

It would be nice if the world helped me and not wait... we always glad to see new contributors

@frederikhors
Copy link

Believe me, I would love to know where to start to help you. Geniuses like you often underestimate themselves.

@ludofischer
Copy link
Collaborator

I would gladly help tag and publish a release candidate, but I haven't got the permissions though. Don't know if there are changes that still need to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support new PostCSS 8 API
5 participants