-
-
Notifications
You must be signed in to change notification settings - Fork 321
feat: postcss 8 and new modern postcss API #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you separate PRs, one plugin = one PR, PostCSS 8 should have compatibility with existing plugins, so we will have only warnings, if you faced with a error, need report to postcss
repo
Too many other packges depend on the previous API. Upgrade again once cssnano migrates. WATCH: cssnano/cssnano#954
Hi, would you find it useful if I converted some of the remaining plugins myself? I could open a pull request against your postcss-8 branch. |
Sounds good. @evilebottnawi do we have to wait for the postcss fixes you were working on to continue in this? |
@anikethsaha I think all problems fixes in 8.1, so we can continue to update |
Shall I start from |
Sure, |
All right. BTW, when I run |
Done in master |
Please can you release it? The world is waiting for you. |
It would be nice if the world helped me and not wait... we always glad to see new contributors |
Believe me, I would love to know where to start to help you. Geniuses like you often underestimate themselves. |
I would gladly help tag and publish a release candidate, but I haven't got the permissions though. Don't know if there are changes that still need to be merged. |
Adding support for new postcss 8 and its new API
Status
should not crash when node.raws.value is null
not working properly as postcss runner is not able to run the plugin - maybe the postcss is< 8
there, not sure. error'true' is not a postcss plugin
when using thepostcss-simple-vars
plugintoModules
plugin's visitor keys are not being visited. But the plugin is being called. Need to fix that.