This repository was archived by the owner on Jun 6, 2022. It is now read-only.
change from global walk to AtRule #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks, @alexgagnon ! |
|
This was merged back in May last year, yet it it's still not been released. Any word on when that will be? |
romainmenke
pushed a commit
to csstools/postcss-plugins
that referenced
this pull request
Jun 1, 2022
* change to using atrule * cleanup Co-authored-by: alexgagnon <alex@monad.media>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the AtRule is the preferred way to ensure plugin interoperability (for example, the current version of postcss-custom-media was failing when used in conjunction with postcss-mixins). This fix is to addresses that by moving the transform logic into AtRule as opposed to walking the root a single time.