This repository was archived by the owner on Jun 6, 2022. It is now read-only.
By matching anything after the custom selector we avoid a potential p… #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roblem with commas. We should trust postcss to not give us multiple selectors in its array
…d to have removed
|
Thanks! 👻 |
yisibl
added a commit
that referenced
this pull request
Jun 3, 2015
By matching anything after the custom selector we avoid a potential p…
|
@yisibl can you release this patch ? |
|
I need to add more test cases. |
|
This is better than nothing for now. You can just release something later if you fix other issues. Move fast, break things ^^ |
|
Done! |
|
If you want more test cases let me know. I can throw a suite together tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roblem with commas. We should trust postcss to not give us multiple selectors in its array
This just simply avoids the check for , on the last part of the regex. Postcss takes care of splitting the selectors so we shouldn't worry.
I attempted a better solution, as this regex will reject some valid selectors the use of \w ignores unicode for example. This solution just ended up in a rabbit hole of regex as well. I think its better to land this patch then rewrite this to use the postcss-css ast when it lands.