This repository was archived by the owner on Jun 6, 2022. It is now read-only.
Fixed: No more useless warnings for undefined non custom selectors #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Changed: simpler message when a custom selector is undefined - Changed: warnings now use PostCSS message API - Some fixes in the Changelog + simpler formatting - Added some references in the Changelog Prepared as 2.2.0 Close #22
|
Review will be simpler if you use the github trick w=1 https://github.com/postcss/postcss-custom-selectors/pull/23/files?w=1 |
|
I just moved the flag test in the right place (at least, I think that's the right place ^^). |
|
I guess you can merge it and just release it :) |
|
Good job! Thank you every much！ |
yisibl
added a commit
that referenced
this pull request
Jul 1, 2015
Fixed: No more useless warnings for undefined non custom selectors #23
|
You didn't push the release as a git tag ;) |
|
Please hold on. |
|
it seems there is still a bug, see #20 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Prepared as 2.2.0
Close #22