This repository was archived by the owner on Jun 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semigradsky
commented
Feb 5, 2017
package.json
Outdated
"tape": "^4.0.0" | ||
}, | ||
"scripts": { | ||
"prepublish": "babel src --out-dir dist", | ||
"lint": "eslint .", | ||
"tape": "babel-tape-runner 'test/*.js'", | ||
"tape": "babel-tape-runner test/*.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With quotes not working on Windows
Semigradsky
commented
Feb 5, 2017
@@ -11,9 +11,9 @@ function transform(input, opts = {}, postcssOpts = {}) { | |||
test("@custom-selector", function(t) { | |||
t.equal( | |||
transform( | |||
`` | |||
"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix lint error
Semigradsky
commented
Feb 5, 2017
@@ -24,21 +24,19 @@ | |||
"README-zh.md" | |||
], | |||
"dependencies": { | |||
"balanced-match": "^0.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old dependency?
Semigradsky
commented
Feb 5, 2017
"postcss": "^5.0.0", | ||
"postcss-selector-matches": "^2.0.0" | ||
}, | ||
"devDependencies": { | ||
"babel": "^5.5.8", | ||
"babel-eslint": "^3.1.15", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's no longer necessary
01da82a
to
8af353b
Compare
8af353b
to
62ca821
Compare
MoOx
approved these changes
Feb 6, 2017
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31