Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Safe postcss values parser #17

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Conversation

Antonio-Laguna
Copy link
Member

No description provided.

Copy link
Collaborator

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the kindest thing for users. The only alternative — and this is up to you — would be to put the try/catch into getReplacedValue.

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I actually like the try catch in index.js but have no strong opinion either way.

@Antonio-Laguna Antonio-Laguna merged commit 1da206b into main Nov 18, 2021
@Antonio-Laguna Antonio-Laguna deleted the safe-postcss-values-parser branch November 18, 2021 16:49
romainmenke pushed a commit to csstools/postcss-plugins that referenced this pull request Nov 19, 2021
* Dev dependencies using ranges consistently with other packages

* Ignoring unknown words

* If there's an exception during parsing, do not let it blow up

* Adding tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants