fix browserslist support queries #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Jul 11, 2023
Comment on lines
+2
to
+16
| export const browsersWithSupportStats = [ | ||
| 'and_chr', | ||
| 'and_ff', | ||
| 'android', | ||
| 'chrome', | ||
| 'edge', | ||
| 'firefox', | ||
| 'ie', | ||
| 'ios_saf', | ||
| 'op_mini', | ||
| 'op_mob', | ||
| 'opera', | ||
| 'safari', | ||
| 'samsung', | ||
| ]; |
There was a problem hiding this comment.
If this includes something that we don't have data for, like baidu and the browserslist query of the user also includes one of these then the internal logic in postcss-preset-env will always transpile everything.
I've moved this to a separate file and I am not using this a filter consistently throughout the codebase.
romainmenke
commented
Jul 11, 2023
Comment on lines
+9
to
+11
| .test-custom-properties { | ||
| order: var(--order); | ||
| } |
There was a problem hiding this comment.
var() is not transpiled, and this matches the expectations for this test.
|
Wow, thank you so much for the blazing-fast turn around! Good work! 🚀 |
|
We still have to release this, but we will do so as soon as possible 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #1041
On the site :
I didn't really want to provide UI to communicate error messages.
alert()should be fine for now 😄