improve support for open-props #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Jul 21, 2023
| } | ||
|
|
||
| return Infinity; | ||
| return 10_000_000; |
Member
Author
There was a problem hiding this comment.
Infinity worked, but limited what was possible.
You can't do Infinity - 100 or Infinity * 10.
| return; | ||
| } | ||
|
|
||
| const thisCascadeLayer = cascadeLayerNumberForNode(decl, cascadeLayersOrder); |
Member
Author
There was a problem hiding this comment.
cascadeLayerNumberForNode(decl, cascadeLayersOrder);
This looks at the immediate parent, in this case a rule with a selector is the parent of the decl, it will never find a layer rule.
This typo was introduced when updating all three postcss-custom-* plugins. The other two are for at-rules where the immediate parent can be a layer rule.
Changed to : cascadeLayerNumberForNode(rule, cascadeLayersOrder);
…ea-turtle-631f2b7716
…ea-turtle-631f2b7716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-propsis something that users will want to combine withpostcss-global-data.However I encountered two issues and then discovered 1 more :
postcss-global-dataopen-propsuses the zero specificity:where(html)postcss-custom-propertieshad a typo and was brokenFixing support for npm packages was relatively simple.
Adding support for
:where(html)was also straight forward and simplifies the plugin as a whole. Because it now just supports variations ofhtml/:rootand checks their specificity.