Skip to content

fix module resolution #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romainmenke
Copy link
Member

This was broken and that it was broken was noticeable in more complex workspace configurations.

For design tokens we want to resolve from the current file that has the @design-token statement.

For global data we want to resolve from process.cwd as the paths are defined in a postcss config file.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, good catch!

@romainmenke romainmenke merged commit 2cea66c into main Aug 21, 2023
@romainmenke romainmenke deleted the fix-module-resolution--considerate-lionfish-cd791bad27 branch August 21, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants