postcss-initial
#1121
Merged
postcss-initial
#1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Sep 16, 2023
plugin-packs/postcss-preset-env/test/layers-basic.preserve.true.expect.css
Show resolved
Hide resolved
Antonio-Laguna
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Looking great as usual!
I'm wondering if plugins/postcss-initial/src/properties.ts should be better formatted for ease of maintenance since it's a very long list as it stands. However, I don't see those values changing too much (if any) so feel free to ignore!
Thanks for this!! 🙇
Good point! Makes it much easier to review mutations :) |
johannes-weber
pushed a commit
to cloudscape-design/theming-core
that referenced
this pull request
Dec 11, 2023
Replacing the plugin because: - postcss-initial had serious issues and was not maintained anymore (csstools/postcss-plugins#1121) - there is an issue, impacting us, with the `all` shorthand property which also includes the `direction` - this should not be part of the shorthand one as specified (see PR for details: maximkoretskiy/postcss-initial#53).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reported on Discord that the original plugin wasn't maintained and had some serious issues. On inspection I agree that the issues are sufficiently important to do a fork.