only produce valid fallback values #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Dec 1, 2023
| @@ -212,7 +212,7 @@ h1.test-custom-selectors:not(.does-not-exist), h2.test-custom-selectors:not(.doe | |||
| } | |||
|
|
|||
| .test-color-functional-notation { | |||
| color: rgba(178, 34, 34, 0.5); | |||
| color: rgba(179, 34, 34, 0.5); | |||
There was a problem hiding this comment.
This was always wrong, the color package is much more correct than what existed in the functional notation plugin.
| @@ -1,6 +1,6 @@ | |||
| import type { Node, AtRule } from 'postcss'; | |||
|
|
|||
| const supportsCheck = /(\(color: rgb(a?)\(0 0 0 \/ 0)|(\(color: hsl(a?)\(0 0% 0% \/ 0)/i; | |||
| export const rgb_hsl_functionRegex = /(?:rgb|hsl)a?\(/i; | |||
There was a problem hiding this comment.
Better to avoid hard coding to much of the supports conditions.
A simplistic check is fine here.
| @@ -99,7 +103,7 @@ const postcssPlugin: PluginCreator<pluginOptions> = (opts?: pluginOptions) => { | |||
|
|
|||
| if (options.enableProgressiveCustomProperties && options.preserve) { | |||
| return { | |||
| postcssPlugin: 'postcss-color-function', | |||
| postcssPlugin: 'postcss-color-functional-notation', | |||
There was a problem hiding this comment.
Some unfortunate copy/paste in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #1185