-
-
Notifications
You must be signed in to change notification settings - Fork 75
fix types #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix types #1200
Conversation
…hub.com/csstools/postcss-plugins into fix-types--persistent-puffin-26bee81a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unused at this time, but I am hoping to use it to resolve : #1201
Actually running it generates hundreds of markdown files with API docs.
So I want to save that for a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I did a general overview as this became nasty to review!
I feared as much :/ Thank you for checking all this 🙇 |
fixes : #1031
This change makes a different tradeoff.
Instead of trying to have correct types for all users and failing to do so, we could choose to only provide types for part of our users.
In practice our current typings and the entries in
package.json
are broken.I think they only work for those who write es module syntax while configuring their TypeScript project for very old node.
I think it's better to make sure it works correctly for modern TypeScript in es modules.
I am making the assumption that those who value typings in build tools are much more likely to be also using es modules for build scripts.
Focussing on es modules, modern TypeScript and modern node has the benefit of being future proof.
The general idea remains the same :
I don't think it is needed to review this change in it's entirety, just too many generated files changed.
example change :
color-helpers
: