nesting editions #1305
Merged
nesting editions #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igent-alaskan-malamute-d9a22039d1
Antonio-Laguna
approved these changes
Mar 5, 2024
romainmenke
commented
Mar 6, 2024
| ); | ||
|
|
||
| if (options.noIsPseudoSelector) { | ||
| throw new Error('The `noIsPseudoSelector` option is no longer supported. Migrate your CSS to use the latest CSS nesting syntax.'); |
There was a problem hiding this comment.
We can't throw here because postcss-preset-env sets this option when a user targets very old browsers.
That behavior already has a comment to remove it in a next major.
|
Thank you reviewing @Antonio-Laguna 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a plugin option
editionto toggle between implementations.The
editiondoesn't refer to a specification version, but rather our implementation.Edition
2024-02overview::is()pseudo-class is no longer optionalandkeyword@nestis removed from the specificationI am choosing not to re-order declarations and nested rules in this new edition because we actually know that this is a major pain point and I want to give users hands on experience with what it could be if w3c/csswg-drafts#8738 is adopted.