Skip to content

PostCSS Custom Properties – add tests for variables with url() #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2022
Merged

PostCSS Custom Properties – add tests for variables with url() #135

merged 1 commit into from
Jan 8, 2022

Conversation

marcalexiei
Copy link
Contributor

Follo up to PR 262.

@romainmenke romainmenke merged commit 12a8d33 into csstools:main Jan 8, 2022
@romainmenke
Copy link
Member

@marcalexiei Thank you for this.

I added some more url() cases after merging this PR.
With the previous parser we have also seen issues with data urls and want to get a signal if there is a regression with the current value parser.

@marcalexiei marcalexiei deleted the feature/custom-properties-add-test-url branch January 8, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainmenke romainmenke romainmenke left review comments

Assignees
No one assigned
Labels
plugins/postcss-custom-properties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcalexiei @romainmenke