Skip to content

add raytrace gamut mapping method #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Apr 13, 2024

This changes the gamut mapping method to a newer algorithm developed by @facelessuser
It will further reduce chroma and preserve lightness and hue better than the current version in the specification. This is favorable because the priorities for CSS in order are : lightness > hue > chroma.

It also has other properties which make it more interesting for browsers.

Given our unique context of generating fallback values we have more room to experiment as long as the result is never broken. This change, as far as I can tell, never produces colors that are visually radically different.

Rolling out this changes means that we can gather feedback on the new algorithm. If any unexpected results surface we can undo this change.

@romainmenke romainmenke force-pushed the add-raytrace-gamut-mapping-method--philosophical-kudu-9c14de86af branch from ba5568e to 808f838 Compare April 13, 2024 21:39
@romainmenke romainmenke marked this pull request as ready for review April 21, 2024 09:57
@romainmenke romainmenke merged commit f2f3d2b into main Apr 21, 2024
@romainmenke romainmenke deleted the add-raytrace-gamut-mapping-method--philosophical-kudu-9c14de86af branch April 21, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant