add raytrace gamut mapping method #1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49b92bc to
ba5568e
Compare
ba5568e to
808f838
Compare
romainmenke
commented
Apr 14, 2024
…ical-kudu-9c14de86af
…pping-method--philosophical-kudu-9c14de86af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the gamut mapping method to a newer algorithm developed by @facelessuser
It will further reduce chroma and preserve lightness and hue better than the current version in the specification. This is favorable because the priorities for CSS in order are :
lightness > hue > chroma.It also has other properties which make it more interesting for browsers.
Given our unique context of generating fallback values we have more room to experiment as long as the result is never broken. This change, as far as I can tell, never produces colors that are visually radically different.
Rolling out this changes means that we can gather feedback on the new algorithm. If any unexpected results surface we can undo this change.