postcss-custom-properties : fix types and some small bugs
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Jan 9, 2022
| @@ -235,6 +235,27 @@ module.exports = { | |||
| stage: 0 | |||
| } | |||
| }, | |||
| 'import:ch88': { | |||
There was a problem hiding this comment.
This is very much broken.
postcss-custom-properties : fix typespostcss-custom-properties : fix types and some small bugs
Antonio-Laguna
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Nice one, will keep an eye on #140 and potentially continue discussions there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.mjsinimportFromoverrideImportFromWithRootoptiontypings
This plugin was a good example of how
.d.tsfiles for typescript are often incorrect.They are created manually without any tool analyses to check correctness.
Better to have true typescript as we then also get all the help from the right tools.
.mjsThe plugin actually already support
.mjsinimportFrombut this was not allowed..mjsfile.unicode
This was a tiny fix.
One less regexp and it works.
overrideImportFromWithRootThis really is a matter of perspective and both orders are equally valid.
They both allow different tactics and features.
postcss/postcss-custom-properties#222
This was updated a while back as a minor version bump but this was actually a breaking change.
I fear not having an option that controls this will just cause someone to reverse it again in the future.
fixes : postcss/postcss-custom-properties#255
fixes : postcss/postcss-custom-properties#237
fixes : postcss/postcss-custom-properties#231