Skip to content

fix postcss 8.2.x compat #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Jan 10, 2022

We do not support PostCSS v8.2.5 any more but as some have this version pinned by tools we can do a minimal effort to help them out.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

IMHO we should add links to #147

Furthermore, I'm inclined to point to vercel/next.js/issues/33135 for a couple of reasons:

  • So it's obvious we're fixing a Next.js issue.
  • Easier navigation

Let me know your thoughts here.

@romainmenke
Copy link
Member Author

I was hesitant to point to one individual tool repackager as there are so many these days.
I bet more are doing it wrong or less than ideal.

Even if I have strong personal opinions about this trend it is however the reality of frontend development today. Keeping it vague might be more productive in the long run :)

@Antonio-Laguna
Copy link
Member

It's not a finger pointing thing IMHO but rather relating these two tools and one issue, Tomorrow could be Tailwind 😂

Won't enforce it though so will leave it up to you.

Thoughts on linking the original issue though?

@romainmenke
Copy link
Member Author

Hehe, tailwind actually does this correctly.

https://github.com/tailwindlabs/tailwindcss/blob/62569092e7ba79fc45f77451c179b3f6cc0f80f8/package.json#L64

I have added the link to the original issue in the changelog.
Indeed a good addition to track this change back in the future!

@romainmenke romainmenke merged commit c374d4d into main Jan 11, 2022
@romainmenke romainmenke deleted the fix-postcss-8.2.5-compat--sympathetic-himalayan-489a349458 branch January 11, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants