Enable full CI for CLI #17
Conversation
92e9422 to
9392f63
Compare
…efined' at the top level of an ES module, and has been rewritten
|
@Antonio-Laguna any opinions on squash commits when merging PR's? |
|
@romainmenke I completely agree. I've been avoiding that for now unless it was enforced since I wasn't sure if it affected the monorepo migration. I can enable squash as the only option here |
| @@ -1,4 +1,4 @@ | |||
| import fsp from 'fs/promises'; | |||
| import { promises as fsp } from 'fs'; | |||
There was a problem hiding this comment.
I often just do this
| import { promises as fsp } from 'fs'; | |
| import fs from 'fs/promises'; |
But feel free to leave it like this if you want to be specific
There was a problem hiding this comment.
I mostly use the specific naming. This is more a reminder for myself that I imported the promises API further down in the code. :)
| # Zero out result file | ||
| echo '' > ./test/cli/basic.result.css; | ||
|
|
||
| # Test with long flag | ||
| postcss-base-plugin ./test/cli/basic.css --output ./test/cli/basic.result.css | ||
|
|
||
| # Check result | ||
| git --no-pager diff --no-index --word-diff ./test/cli/basic.expect.css ./test/cli/basic.result.css | ||
| if [[ "$OSTYPE" == "msys" ]]; then | ||
| # CRLF on Windows makes it hard to test with base64 encoded sourcemaps |
Enforcing it would be fine I think. |
integration after
base-cliandpostcss-base-pluginwere merged.