-
-
Notifications
You must be signed in to change notification settings - Fork 75
enable full CI #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable full CI #27
Conversation
…-killer-whale-39dce2f576
…-killer-whale-39dce2f576
…as-monkey-d20d7b3681' into enable-full-ci--witty-killer-whale-39dce2f576
This reverts commit ebe8aca.
@romainmenke this is erroring as you can see above and also there seems to be a cancelled run, let me know if you want to discuss this. |
@Antonio-Laguna yeah, it's failing because some plugins in this repo have breaking changes. In older node versions those plugins are pulled from npm instead of the workspace. This is not something that we can (or should) solve. CI will become green once we release packages and update versions in The skipped test is because it's a workflow with a matrix strategy. |
Sounds sensible! |
c1e1d32
into
postcss-preset-env--generous-patas-monkey-d20d7b3681
* Migrate postcss-preset-env * fixes * enable full CI (#27) * enable full CI * resolve some rollup warnings * cleanup * fixes * update tests * postcss-tape --ci * fix tests * fix tests * fix tests * fix tests * fix tests * cleanup * fix tests * fix tests * fix tests * Revert "fix tests" This reverts commit ebe8aca. * add separate workflow for older node versions * better workflow description * update tests
Checks :
Caveats :
Node 12|14 don't have workspaces support.
For small changes this wont matter as dependencies are pulled from npm.
CI will fail when there is a breaking change in a plugin that affects
postcss-preset-env
To handle this the node 12|14 checks are run in a separate workflow.
This PR itself is currently failing because of this.
-> some plugins have breaking changes in how they need to be imported.
This will require a human to inspect the output and see if an error is expected or not.
Once everything has been released CI will be green again.
fixes : #9