Skip to content

enable full CI #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Nov 21, 2021

Checks :

  • eslint
  • postcss-tape
  • CLI cross platform
  • deno
  • multiple node versions

Caveats :

Node 12|14 don't have workspaces support.
For small changes this wont matter as dependencies are pulled from npm.

CI will fail when there is a breaking change in a plugin that affects postcss-preset-env
To handle this the node 12|14 checks are run in a separate workflow.

This PR itself is currently failing because of this.
-> some plugins have breaking changes in how they need to be imported.

This will require a human to inspect the output and see if an error is expected or not.
Once everything has been released CI will be green again.

fixes : #9

@romainmenke romainmenke self-assigned this Nov 21, 2021
@romainmenke romainmenke changed the base branch from main to postcss-preset-env--generous-patas-monkey-d20d7b3681 November 28, 2021 18:02
@romainmenke romainmenke marked this pull request as ready for review November 29, 2021 07:05
@Antonio-Laguna
Copy link
Member

Antonio-Laguna commented Nov 29, 2021

@romainmenke this is erroring as you can see above and also there seems to be a cancelled run, let me know if you want to discuss this.

@romainmenke
Copy link
Member Author

@Antonio-Laguna yeah, it's failing because some plugins in this repo have breaking changes.
postcss-preset-env has been updated to match.

In older node versions those plugins are pulled from npm instead of the workspace.
So in node 12 and 14 we have a postcss-preset-env that was updated and expects new releases of for example css-blank-pseudo. But it downloads the current version of css-blank-pseudo

This is not something that we can (or should) solve.
The issue will go away over time when all node LTS versions have workspaces support.

CI will become green once we release packages and update versions in postcss-preset-env.

The skipped test is because it's a workflow with a matrix strategy.
Once there is a single failure the others are cancelled.

@Antonio-Laguna
Copy link
Member

Sounds sensible!

@Antonio-Laguna Antonio-Laguna merged commit c1e1d32 into postcss-preset-env--generous-patas-monkey-d20d7b3681 Nov 29, 2021
@Antonio-Laguna Antonio-Laguna deleted the enable-full-ci--witty-killer-whale-39dce2f576 branch November 29, 2021 08:22
romainmenke added a commit that referenced this pull request Nov 29, 2021
* Migrate postcss-preset-env

* fixes

* enable full CI (#27)

* enable full CI

* resolve some rollup warnings

* cleanup

* fixes

* update tests

* postcss-tape --ci

* fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* cleanup

* fix tests

* fix tests

* fix tests

* Revert "fix tests"

This reverts commit ebe8aca.

* add separate workflow for older node versions

* better workflow description

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CI
2 participants