postcss-gradients-interpolation-method #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s--diligent-prawn-de683864e3
Comment on lines
+109
to
+116
| func.nodes.splice( | ||
| // 1 before the current node | ||
| func.nodes.indexOf(node) - 1, | ||
| // remove none | ||
| 0, | ||
| // insert these : | ||
| comma, color, | ||
| ); |
Antonio-Laguna
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #85
fixes : #233
related to : #177
It uses
calcto avoid having to calculate the positions of color stops.This makes it possible to support
calcandvarvalues in positions.just works :
linear-gradient(in oklch 90deg, black 20% var(--perc-50),blue 70% 75%);Technically allowed to have
varin colors but the futurecolor-mixplugin won't be able to handle those.Color stops with only a color and Interpolation hints are not supported.
Note : this plugin in isolation is useless.
A separate plugin is required to downgrade
color-mix().This approach makes it possible to have all
color-mixlogic in a single plugin.I think we can merge this as is just to get the ball rolling.