various fixes #289
Merged
various fixes #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Mar 6, 2022
Comment on lines
+95
to
+106
| .repeating-conic { | ||
| background: repeating-conic-gradient( | ||
| from 3deg, | ||
| hsl(200, 100%, 50%) 0deg,hsl(200, 100%, 50%) 15deg, | ||
| hsl(200, 100%, 60%) 10deg, hsl(200, 100%, 60%) 30deg | ||
| ); | ||
| background: repeating-conic-gradient( | ||
| from 3deg, | ||
| hsl(200, 100%, 50%) 0deg 15deg, | ||
| hsl(200, 100%, 60%) 10deg 30deg | ||
| ); | ||
| } |
There was a problem hiding this comment.
The value in postcss-value-parser for hsl(200, 100%, 60%) is hsl.
So any double position gradients with CSS functions were broken :/
.repeating-conic {
background: repeating-conic-gradient(
from 3deg,
hsl(200, 100%, 50%) 0deg,hsl 15deg,
hsl(200, 100%, 60%) 10deg, hsl 30deg
);
}
Comment on lines
+19
to
+25
| while (a.nodes[ia] && a.nodes[ia].type === 'space') { | ||
| ia++; | ||
| } | ||
|
|
||
| while (b.nodes[ib] && b.nodes[ib].type === 'space') { | ||
| ib++; | ||
| } |
There was a problem hiding this comment.
space nodes are now ignored when matching.
Makes it easier to match cases with irregular spacings : rgba(255,0, 255 , 1)
| "postcss": "^8.3" | ||
| }, | ||
| "devDependencies": { | ||
| "dependencies": { |
There was a problem hiding this comment.
Temporary laps in focus on my end?
Antonio-Laguna
approved these changes
Mar 7, 2022
|
LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
double-position-gradientstransforms broke with CSS functions.package.jsonerror ingradients-interpolation-methodcolor-mixinprogressive-custom-properties