Skip to content

Conversation

@romainmenke
Copy link
Member

  • remove browser.js and keep browser-legacy.js (both were also broken)
  • use postcss-selector-parser, used to be a regexp and was broken in some cases (e.g. [foo=":blank"])
  • rest follows work done in css-has-pseudo
  • add warning about :not(:blank)

remove browser.js and keep browser-legacy.js

Keeping both adds a lot of complexity with little benefits (±200 bytes less).
Having just one that works in as many places as possible is best going forward imho.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive!

@Antonio-Laguna Antonio-Laguna merged commit 8d74b85 into main Nov 23, 2021
@Antonio-Laguna Antonio-Laguna deleted the css-blank-pseudo--practical-stoat-785ec68d5c branch November 23, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants