-
-
Notifications
You must be signed in to change notification settings - Fork 75
Preset env home revamp #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wser cache" This reverts commit be05d4b.
romainmenke
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Thank you for doing another port and updating the landing page :)
I suggest we merge this as-is and iterate on it where needed 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another site rewriting. Astro is too experimental which is great but we're betting on stability and long term maintenance. This PR changes Astro by Eleventy.
This also tackles a long-forgotten issue from @ai which revamps the Homepage. Thanks to @severin-d too which did the original work and I was able to get most of that back :) Removed gulp / grunt since they're no longer relevant and replaced with PostCSS disclaimer.
Sadly this removes the playground for now as it doesn't seem trivial to get updated, mostly due to node bindings with
importFrom
which are being discussed here: #192Fixes #254