Skip to content

improve pseudo element handling #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainmenke
Copy link
Member

The previous change to all this logic left the order of simple selectors of the same type in tact. This worked for this case :

:is(:hover, :focus)::before {
  color: red;
}

But didn't work for some other cases.
With all the tools available to stylesheet authors to compose selectors (nesting, :is, custom selectors, ...) it is better to be more forgiving and have an explicit order for pseudo elements vs pseudo classes.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! Looks more solid

@Antonio-Laguna Antonio-Laguna merged commit 6d2300f into main Apr 4, 2022
@Antonio-Laguna Antonio-Laguna deleted the improve-pseudo-element-handling--courteous-platypus-f073470859 branch April 4, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants