Fix race condition issue of postcss-custom-properties #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@malash could you merge |
…to fix-331 * 'main' of https://github.com/csstools/postcss-plugins: Reverting due to security concerns Switching target Enabling tests on pull_request
|
@Antonio-Laguna PR rebased and all CI passed. |
Antonio-Laguna
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed #331 . For more background please see that issue.
As I understand the
preparefunction is designed to store context variables for each CSS file, while the plugin function itself should contain some common code across CSS files, like some constant variables only related toopts.In this case the
customPropertiesis mutated and read between listeners. So it should be placed inpreparerather tha plugin function.Ref: https://github.com/postcss/postcss/blob/main/docs/writing-a-plugin.md#step-3-find-nodes