Skip to content

Ignore has inside supports #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Ignore has inside supports #333

merged 3 commits into from
Apr 12, 2022

Conversation

Antonio-Laguna
Copy link
Member

This ignores :has() rules defined within @support selector check (only if it's checking :has() support.

Note that the selector syntax differs from the issue. The issue was suggesting @supports (selector(:has(foo))) whereas the syntax seems to be @supports selector(:has(foo)).

Fixes #312

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing :)

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Antonio-Laguna Antonio-Laguna merged commit f3a0552 into main Apr 12, 2022
@Antonio-Laguna Antonio-Laguna deleted the ignore-has-inside-supports branch April 12, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore :has() selectors nested inside @supports rules
2 participants