Skip to content

PostCSS Stepped Value Functions #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 2, 2022
Merged

Conversation

Antonio-Laguna
Copy link
Member

@Antonio-Laguna Antonio-Laguna commented Apr 30, 2022

Adds support for Stepped Value Functions which are part of the CSS Values and Units Module Level 4.

This enables support for:

  • round()
  • mod()
  • rem()

They were added to the spec in 2020 and little has changed since then. Because of that, it has been listed as Stage 2 on the CSSDB

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Added a few notes :)

Antonio-Laguna and others added 11 commits May 1, 2022 11:11
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
@Antonio-Laguna Antonio-Laguna marked this pull request as ready for review May 1, 2022 15:14
@Antonio-Laguna Antonio-Laguna requested a review from romainmenke May 1, 2022 15:14
@Antonio-Laguna Antonio-Laguna self-assigned this May 1, 2022
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things, rest looks perfect!

Antonio-Laguna and others added 2 commits May 2, 2022 11:10
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Antonio-Laguna and others added 2 commits May 2, 2022 11:12
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
@Antonio-Laguna
Copy link
Member Author

Antonio-Laguna commented May 2, 2022

@romainmenke thanks a lot for catching those, will keep this in mind for the future!

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Exited to get this out there 🎉

@Antonio-Laguna Antonio-Laguna merged commit 003595e into main May 2, 2022
@Antonio-Laguna Antonio-Laguna deleted the feature/stepped-value-functions branch May 2, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants