Skip to content

package json lint error as github annotation #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented May 1, 2022

Noticed that there wasn't a github annotation for lint issues in package.json.
Then also noticed that some of the annotations from postcss-tape didn't resolve to the correct path.

This fixes both issues.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks! Learning a lot from these annotations!

@romainmenke romainmenke merged commit 2edab4f into main May 1, 2022
@romainmenke romainmenke deleted the package-json-lint-gh-annotation--reliable-poison-dart-frog-eb718d5342 branch May 1, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants