Skip to content

Migrate postcss-image-set-function #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2021
Merged

Migrate postcss-image-set-function #37

merged 5 commits into from
Nov 28, 2021

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Nov 27, 2021 •
edited
Loading

  • the original still used Once.
  • converting it to Declaration resulted in an infinite loop.
  • migrated to typescript to aid in debugging.

The end result should work exactly the same, even if the generated CSS is a bit different.
The previous version generated extra (unneeded) Rule's for individual Declaration's

Antonio-Laguna
Antonio-Laguna approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Antonio-Laguna Antonio-Laguna merged commit cc42421 into main Nov 28, 2021
@Antonio-Laguna Antonio-Laguna deleted the postcss-image-set-function branch November 28, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-Laguna Antonio-Laguna Antonio-Laguna approved these changes

Assignees

@Antonio-Laguna Antonio-Laguna

Labels
plugins/postcss-image-set-function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainmenke @Antonio-Laguna